build: Use macOS sysroot, arch, minversion for generating bitcode #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To solve a problem finding system headers when building with command line tools instead of Xcode. Replaces some commented out code, as this should be a more general solution to the same problem. Adding arch and minversion for completeness, not because of a particular known problem, but better to be sure everything matches up. Signed-off-by: Brecht Van Lommel <[email protected]>
brechtvl
force-pushed
the
macos-sysroot
branch
from
889b2a1 to
689fd8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To solve a problem finding system headers when building with command line tools instead of Xcode. Replaces some commented out code, as this should be a more general solution to the same problem.
Adding arch and minversion for completeness, not because of a particular known problem, but better to be sure everything matches up.
Tests
N/A
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.